Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: MarshalPKCS8PrivateKey doc says RSA private key while it supports more than that [1.13 backport] #37067

Closed
gopherbot opened this issue Feb 5, 2020 · 3 comments
Closed

crypto/x509: MarshalPKCS8PrivateKey doc says RSA private key while it supports more than that [1.13 backport] #37067

gopherbot opened this issue Feb 5, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.8

Comments

@gopherbot
Copy link

@katiehockman requested issue #36735 to be considered for backport to the next 1.13 minor release.

@gopherbot please backport to 1.13 and 1.14
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 5, 2020
@gopherbot gopherbot mentioned this issue Feb 5, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.8 milestone Feb 5, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/217998 mentions this issue: [release-branch.go1.13] crypto/x509: fix godoc for MarshalPKCS8PrivateKey

@gopherbot
Copy link
Author

Closed by merging 17ac3f6 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Feb 5, 2020
@katiehockman
[release-branch.go1.13] crypto/x509: fix godoc for MarshalPKCS8Privat…
17ac3f6 
…eKey

Updates #36735
Fixes #37067

Change-Id: I93f005d78f4bfac773272995b165172461bae92f
Reviewed-on: https://go-review.googlesource.com/c/go/+/217917
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
(cherry picked from commit 7a36fa4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/217998
@dmitshur
Copy link
Contributor

dmitshur commented Feb 6, 2020

This backport has been approved because it is a documentation fix.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 6, 2020
@golang golang locked and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.8
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot