Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/text/encoding/simplifiedchinese: infinite loop decoding HZGB2312 strings ending with ~ #37060

Closed
smariot opened this issue Feb 5, 2020 · 2 comments
Closed

x/text/encoding/simplifiedchinese: infinite loop decoding HZGB2312 strings ending with ~ #37060

smariot opened this issue Feb 5, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@smariot
Copy link

smariot commented Feb 5, 2020

What version of Go are you using (go version)?

$ go version
go version go1.13.7 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/smariot/.cache/go-build"
GOENV="/home/smariot/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/smariot/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build492816801=/tmp/go-build -gno-record-gcc-switches"

What did you do?

https://play.golang.org/p/NI4shjahCS_p

What did you expect to see?

I expected the program to terminate.

What did you see instead?

Endlessly increasing memory usage.

Possible fix:

hzgb2312.go:60: replace 

r = utf8.RuneError
with 
r, size = utf8.RuneError, 1
@gopherbot gopherbot added this to the Unreleased milestone Feb 5, 2020
@ianlancetaylor
Copy link
Contributor

CC @mpvl

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 6, 2020
@AlexanderYastrebov
Copy link
Contributor

Duplicate of #35118 fixed by https://golang.org/cl/220460

@golang golang locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@cagedmantis @AlexanderYastrebov @ianlancetaylor @gopherbot @seankhliao @smariot