Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dl/internal/version, dl/gotip: merge gotip into internal/version #37037

Closed
zikaeroh opened this issue Feb 5, 2020 · 4 comments
Closed

dl/internal/version, dl/gotip: merge gotip into internal/version #37037

zikaeroh opened this issue Feb 5, 2020 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@zikaeroh
Copy link
Contributor

zikaeroh commented Feb 5, 2020

dl/internal/version and dl/gotip contain much of the same code. Fixes for issues like #36976 need to be applied to both, even though their underlying operation is nearly identical (including duplicated helpers and tests). internal/version could back gotip instead.

Splitting out from #36976 (comment).

I have a CL chain I'm planning to submit to clean this up (and fix #36976).
@gopherbot
Copy link

Change https://golang.org/cl/217764 mentions this issue: internal/version, gotip: move gotip into internal/version

@dmitshur
Copy link
Contributor

dmitshur commented Feb 7, 2020

/cc @dmitshur @toothrot @cagedmantis

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 7, 2020
@dmitshur dmitshur added this to the Unreleased milestone Feb 7, 2020
@zikaeroh
Copy link
Contributor Author

Any chance my pair of CLs can be reviewed? Not entirely certain who reviews for the dl repo, but I'm hopeful now that 1.14 is out. 🙂

@zikaeroh zikaeroh mentioned this issue Mar 5, 2020
Open
@gopherbot
Copy link

Change https://golang.org/cl/301909 mentions this issue: gotip: fold into internal/version

@golang golang locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @zikaeroh