net: TestLookupNullByte is failing on macOS (and maybe other non-Windows ports) #37031
Labels
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
release-blocker
Testing
An issue that has been verified to require only test changes, not just a test failure.
Milestone
CL 173362 was a part of Go 1.14 changes and fixed a crash in
net.LookupHost
on Windows. It added the testTestLookupNullByte
. A part of that test is not compatible with non-Windows ports such as darwin/amd64, causing the test to fail:Marking as release-blocker because it's a regression, and the test failure is very reproducible. The fix will be small.
The test's primary goal is was to ensure
net.LookupHost("foo\x00bar")
doesn't crash on Windows. Additionally, it happens to check that err != nil on Windows:On darwin/amd64,
net.LookupHost("foo\x00bar")
on my machine/network returns a nil error even with Go 1.13.7:/cc @bradfitz @golang/osp-team I plan to update the test so it either runs only on Windows, or relax the
err == nil
check. Let me know if there are preferences between those two fixes./cc @bradfitz Is it normal that
net.LookupHost("foo\x00bar")
can succeed on macOS? If it's not expected, I believe a separate issue should be filed for that.The text was updated successfully, but these errors were encountered: