Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: create link for release note for each version #37019

Closed
hyangah opened this issue Feb 4, 2020 · 3 comments
Closed

x/tools/gopls: create link for release note for each version #37019

hyangah opened this issue Feb 4, 2020 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Feb 4, 2020

VSCode Go extension detects availability of newer versions of gopls automatically (by querying proxy.golang.org) and suggest upgrade. I want to see the update suggestion message window include the link to the release note.

Currently #33030 serves as a place for release note announcement which makes sense since gopls evolves quickly. I can use the link to the issue but that's rather distracting as more versions are published. Alternatively we can create a short link (encoded with the version tag) for each tagged version and make it point to the corresponding comments. Post v1.0, we can still use the link format to point to the official, formal release note.

@hyangah hyangah added the gopls Issues related to the Go language server, gopls. label Feb 4, 2020
@gopherbot gopherbot added this to the Unreleased milestone Feb 4, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Feb 4, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.4.0 Feb 5, 2020
@heschi
Copy link
Contributor

heschi commented Feb 10, 2020

Perhaps we should just edit the latest minor version's release notes into the top comment.

@heschi
Copy link
Contributor

heschi commented Feb 10, 2020

Done. I vote we keep the notes from the most recent minor series at #33030 (comment), as I've done now.

hyangah added a commit to hyangah/vscode-go-old that referenced this issue Feb 11, 2020
@stamblerre
Copy link
Contributor

Agreed. Closing this issue.

hyangah added a commit to hyangah/vscode-go-old that referenced this issue Feb 28, 2020
@golang golang locked and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants