New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: add support for dark mode #36980
Comments
We're currently discussing this request with our UX team, along with other design feedback we've received for the site. We want to review design feedback we have received as part of a broader redesign, as opposed to make piecemeal decisions. I'll update this issue once we have decided on any changes. /cc @fflewddur |
This isn't just about "the memes", this is about people suffering from light sensitivity or photophobia. |
Folks, unless there’s something new to add, please upvote the original issue description instead of commenting with support. Per golang.org/wiki/NoPlusOne. |
Here's a set of css rules that switches pkg.go.dev to dark mode, it was pretty quick to make thanks to the use of CSS variables! I tested it on qutebrowser v2.2.1 (QtWebEngine 5.15.3, Chromium 87.0.4280.144) Here's the gist: https://gist.github.com/ewen-lbh/d486b8fd662208d9019cf12b6a47caba Note: I didn't do it yet, but wrapping the whole ruleset in a |
Change https://golang.org/cl/326055 mentions this issue: |
Change https://golang.org/cl/326054 mentions this issue: |
Change https://golang.org/cl/326053 mentions this issue: |
Change https://golang.org/cl/326052 mentions this issue: |
Change https://golang.org/cl/326050 mentions this issue: |
Change https://golang.org/cl/332491 mentions this issue: |
Dark theme is now live on pkg.go.dev and will change based on the systems preferred color scheme. |
Looks great! |
It was working on my machine yesterday, but today it doesn't 🤔 |
Is there any way to toggle it? I'm kinda in the opposite boat- I struggle with contrast, so I have dark mode at the system level so I can make out system menus better, and then use light mode on sites so I can read pages easier. |
firefox has a thing to override the theme sent to websites in about:config AFAIK |
You can press
@cespare - since this issue is closed, would you mind filing a new issue? |
I'll leave it to someone more motivated about dark mode. |
I accidentally hit 't' (not knowing I had hit 't') and entered the one-way dark-mode. |
Press |
Is this supposed to be still working? It's bright-white for me...
|
@eliasp Yes, it's still supported and should work. Scroll to the bottom and look for a sun/moon/halfway icon. Clicking it will toggle between light, dark, and auto modes: (The If it's still not working or you're seeing some problem, please file a new issue. Thanks. |
What is the URL of the page with the issue?
All Pages (noticed explicitly on my first use, which was os.ProcessState.Success)
What is your user agent?
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0
What did you expect to see?
Support for my already configured system wide dark mode (via CSS prefers-colour-scheme)
Or at the very least a toggle button somewhere to enable something less eye-searing for those of us working at night or in the dark
What did you see instead?
I didnt. I was blinded.
But in all seriousness, a beautifully designed, if bright white docs page. Which instantly clashed with the rest of my system as it is configured to have a dark GTK theme, et al.
On the old godoc.org, I managed this though a stylus theme, but I'd much rather have first party support on pkg.go.dev.
The text was updated successfully, but these errors were encountered: