Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/releasebot: build release binary in module mode #36950

Closed
dmitshur opened this issue Jan 31, 2020 · 1 comment
Closed

x/build/cmd/releasebot: build release binary in module mode #36950

dmitshur opened this issue Jan 31, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

In the following method:

func (w *Work) buildReleaseBinary() {

The golang.org/x/build/cmd/release binary is built explicitly in GOPATH mode, with a clean, deterministic GOPATH workspace.

releasebot should be updated to build release binary in module mode.

Making the change may result in different versions of its dependencies being used:

  • cloud.google.com/go/storage
  • golang.org/x/sync/errgroup
  • google.golang.org/api/iterator

We should confirm that making this change won't influence a release negatively, and do the switch.

Building the release binary should continue to be reproducible and unaffected by user's local environment. This can be done by overriding environment variables from environment with explicit ones, as it was done when building in GOPATH mode:

r := w.runner(w.Dir, "GO111MODULE=off", "GOPATH="+gopath, "GOBIN="+filepath.Join(gopath, "bin"))
r.run("go", "get", "golang.org/x/build/cmd/release")
@dmitshur dmitshur added help wanted Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. modules labels Jan 31, 2020
@dmitshur dmitshur added this to the Unreleased milestone Jan 31, 2020
@dmitshur dmitshur self-assigned this Jul 12, 2021
@gopherbot
Copy link

Change https://golang.org/cl/334109 mentions this issue: cmd/releasebot: build cmd/release in module mode

@dmitshur dmitshur added this to In Progress in Go Release Team Jul 12, 2021
Go Release Team automation moved this from In Progress to Done Jul 14, 2021
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

2 participants