Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: VS Code breadcrumbs broken with methods #36949

Closed
stamblerre opened this issue Jan 31, 2020 · 2 comments
Closed

x/tools/gopls: VS Code breadcrumbs broken with methods #36949

stamblerre opened this issue Jan 31, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@stamblerre
Copy link
Contributor

See microsoft/vscode-go#3021.

@gopherbot gopherbot added this to the Unreleased milestone Jan 31, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 31, 2020
@stamblerre
Copy link
Contributor Author

After some quick investigation, it seems that this is caused by our use of the hierarchical symbol support to categorized methods below their receiver's type. The behavior of the VS Code extension is to show something like (*a).b at the top level, instead of a, which has a child symbol b(). I think that VS Code's breadcrumbs break because the child symbol's position is not contained within the range of the parent symbol. Based on that behavior, I think that we can fix this by treating methods as top-level symbols.

@stamblerre stamblerre added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 26, 2020
@gopherbot
Copy link

Change https://golang.org/cl/221819 mentions this issue: internal/lsp: fix breadcrumbs when inside of a method

@golang golang locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants