x/build/cmd/releasebot: "about to tag this commit, ok?" prompt UX can be improved #36948
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Projects
Milestone
In the following method:
It asks the user:
I was used to pressing Shift+Y after using other apps like
gcloud components update
, which prompt:But when I did, two things happened:
releasebot
interpreted upper "Y" as a negative response.releasebot
"stopped" by panicking with an error message that wasn't very clear or helpful.Expand below for details:
I suggest two changes to make things better for future releases:
Make
releasebot
ask for and accept upper case "Y" in addition to lower case "y".Make the panic error message more descriptive than just "stopped", so it's faster to realize that
releasebot
is exiting because it received a negative answer. Additionally, exit withlog.Fatalf
rather than printing a panic stack trace.For comparison, this is
gcloud components update
response to a negative answer:The text was updated successfully, but these errors were encountered: