Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: reduce memory usage #36943

Closed
stamblerre opened this issue Jan 31, 2020 · 18 comments
Closed

x/tools/gopls: reduce memory usage #36943

stamblerre opened this issue Jan 31, 2020 · 18 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Performance Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.0

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Jan 31, 2020 •
edited by heschi

This is a general tracking issue for memory usage in gopls. We need to collect data and set goals for usage for a given project size. We also need to work towards reducing the memory usage when staticcheck is enabled (though that may be a separate issue).

If you have a specific problem with gopls using too much memory on your machine, please create a new issue so that we can investigate it separately.

Please include your editor settings and memory debug information with your issue. These are automatically written to the temporary directory (/tmp for Unixes) with names like gopls.1234-5GiB-withnames.zip. If you are uncomfortable sharing the package names of your code, you can share the -nonames zip instead.
@gopherbot gopherbot added this to the Unreleased milestone Jan 31, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 31, 2020
@stamblerre stamblerre mentioned this issue Jan 31, 2020
Closed
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Jan 31, 2020
@nghialm269

This comment has been minimized.

Sign in to view
@patrikeh

This comment has been minimized.

Sign in to view
@guiguan

This comment has been minimized.

Sign in to view
@myitcv

This comment has been minimized.

Sign in to view
@stamblerre

This comment has been minimized.

Sign in to view
@stamblerre stamblerre mentioned this issue Feb 4, 2020
Closed
@vincepri

This comment has been minimized.

Sign in to view
@heschi

This comment has been minimized.

Sign in to view
@trajber

This comment has been minimized.

Sign in to view
@heschi

This comment has been minimized.

Sign in to view
@tianhongw tianhongw mentioned this issue Mar 9, 2020
Closed
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.6.0 Mar 12, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.6.0, gopls/v0.7.0 Apr 2, 2020
@Jacalz

This comment has been minimized.

Sign in to view
@stamblerre

This comment has been minimized.

Sign in to view
@bcmills bcmills mentioned this issue May 21, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/236397 mentions this issue: internal/lsp/cache: intermediate test variants aren't workspace packages

gopherbot pushed a commit to golang/tools that referenced this issue Jun 11, 2020
@heschi
internal/lsp/cache: intermediate test variants aren't workspace packages
ca43edf 
When you write a test in (say) the fmt package, you get a test variant
augmented with the test files. In many cases you also get test variants
of the things the fmt package depends on. The primary test variant,
(fmt [fmt.test]) is interesting to us, because it contains the tests.
But the intermediate variants (testing [fmt.test]) aren't -- the user
can only get to them indirectly. We certainly don't need to fully parse
them.

Treat intermediate test variants as non-workspace packages. This doesn't
accomplish much yet but paves the way for later optimizations.

Updates golang/go#36943.

Change-Id: I1a20abcd2d67767f07132a75a20f098be6f19a76
Reviewed-on: https://go-review.googlesource.com/c/tools/+/236397
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@heschi
Copy link
Contributor

heschi commented Jun 11, 2020

I think the commits I pushed today have improved things significantly for large projects. I'll keep looking for a little bit.

@stamblerre stamblerre mentioned this issue Jun 23, 2020
Closed
@itzmanish

This comment has been minimized.

Sign in to view
@stamblerre stamblerre modified the milestones: gopls/v0.7.0, gopls/v0.5.0 Jun 26, 2020
@heschi
Copy link
Contributor

heschi commented Jul 1, 2020

From the first comment:

If you have a specific problem with gopls using too much memory on your machine, please create a new issue so that we can investigate it separately.

There will be zip files in /tmp with additional memory diagnostic information. Please include one of them. If you are uncomfortable sharing the package names of your code you can pick one with a -nonames suffix, otherwise please upload a --withnames` file.

@iand iand mentioned this issue Jul 17, 2020
Closed
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
@stamblerre
Copy link
Contributor Author

There have been a number of memory improvements in gopls at master. Please try out with the instructions on https://github.com/golang/tools/blob/master/gopls/doc/user.md#unstable-versions, or wait for the next release.

@raghav-clumio
Copy link

@stamblerre just switched to master and it dropped my ram usage from 10 gigs to 1.5gb! Great work guys!

@stamblerre stamblerre mentioned this issue Aug 26, 2020
Closed
@heschi heschi self-assigned this Sep 2, 2020
@gopherbot
Copy link

Change https://golang.org/cl/253577 mentions this issue: gopls/doc: add memory usage info to troubleshooting guide

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.0 Sep 9, 2020
@golang golang locked and limited conversation to collaborators Sep 9, 2021
@rsc rsc unassigned heschi Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Performance Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.0
Development

No branches or pull requests