Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: text can cause overflow on smaller viewports #36935

Closed
ucirello opened this issue Jan 31, 2020 · 2 comments
Closed

x/pkgsite: text can cause overflow on smaller viewports #36935

ucirello opened this issue Jan 31, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite UX Issues that involve UXD/UXR input
Milestone
pkgsite/frontend

Comments

@ucirello
Copy link
Contributor

What is the URL of the page with the issue?

https://pkg.go.dev/crypto/tls?tab=doc

What is your user agent?

Mozilla/5.0 (Linux; Android 10; Pixel 4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.136 Mobile Safari/537.36

Screenshot

Check the screenshots below

What did you do?

Opened the page from a link sent by someone else.

What did you expect to see?

The perfect filled space that we currently have for godoc.org
image

What did you see instead?

image
@ALTree ALTree added the pkgsite label Feb 3, 2020
@gopherbot gopherbot added this to the Unreleased milestone Feb 6, 2020
@julieqiu julieqiu changed the title go.dev: the website doesn't prevent viewport resize x/pkgsite: the website doesn't prevent viewport resize Jun 15, 2020
@julieqiu julieqiu changed the title x/pkgsite: the website doesn't prevent viewport resize go.dev: the website doesn't prevent viewport resize Jun 26, 2020
@julieqiu julieqiu added UX Issues that involve UXD/UXR input NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 26, 2020
@andybons
Copy link
Member

andybons commented Aug 5, 2020

This is because a few pieces of text on https://pkg.go.dev/crypto/tls?tab=doc are causing overflow. Adding word-break: break-word to the appropriate CSS styles should solve the issue.

@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 5, 2020
@andybons andybons changed the title go.dev: the website doesn't prevent viewport resize x/pkgsite: text can cause overflow on smaller viewports Aug 5, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Aug 27, 2020
@julieqiu
Copy link
Member

This issue has been fixed. Closing this issue.

@golang golang locked and limited conversation to collaborators Feb 24, 2022
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite UX Issues that involve UXD/UXR input
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
7 participants
@ucirello @andybons @ALTree @hyangah @julieqiu @gopherbot @pearring