Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: relative links in blog.golang.org posts 404s when followed from the golang.org homepage #36930

Closed
s-chand opened this issue Jan 31, 2020 · 3 comments
Closed

x/website: relative links in blog.golang.org posts 404s when followed from the golang.org homepage #36930

s-chand opened this issue Jan 31, 2020 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@s-chand
Copy link

s-chand commented Jan 31, 2020

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

I visited the Golang.org web page and got a link to an error page which was referenced as though it was available.

I have attached images

What did you expect to see?

The reference to Go 2 Here we come to work or atleast not to display an error

What did you see instead?

I got an lstat error message
Screenshot 2020-01-31 at 16 41 36
Screenshot 2020-01-31 at 16 41 51
@gopherbot gopherbot added this to the Unreleased milestone Jan 31, 2020
@ALTree
Copy link
Member

ALTree commented Jan 31, 2020

Thanks for reporting this.

If you click on that link from the homepage, it goes to golang.org/go2-here-we-come, which 404s, while if you open the blog post (https://blog.golang.org/go1.15-proposals) and then click on the link, it goes to blog.golang.org/go2-here-we-come, which is correct.

cc @toothrot @cagedmantis @dmitshur

@ALTree ALTree changed the title x/website: https://golang.org/ x/website: relative links in blog.golang.org posts 404s when followed from the golang.org homepage Jan 31, 2020
@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 31, 2020
@dmitshur dmitshur self-assigned this Jan 31, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Jan 31, 2020 •
edited

Thanks for the report. When making a code review suggestion in CL 216199, I didn't take it into account that blog posts are embedded directly on golang.org, and thus cannot use relative relative links to other blog.golang.org pages.

I'll send a fix by rolling back CL 216626 which implemented my faulty suggestion, and file an issue about catching this potential problem via a test. Edit: Filed #36944.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 31, 2020
@gopherbot
Copy link

Change https://golang.org/cl/217239 mentions this issue: content/go1.15-proposals.article: revert "use relative links for other blog articles"

@dmitshur dmitshur mentioned this issue Jan 31, 2020
Closed
@golang golang locked and limited conversation to collaborators Jan 30, 2021
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
@dmitshur
[x/blog] content/go1.15-proposals.article: revert "use relative links…
895f9fe 
… for other blog articles"

This reverts CL 216626 (commit 8bf1296992b6579acabcba62cc6cd0efe039c38a).

We cannot rely on relative links in blog posts to stay relative to
blog.golang.org, because blog posts are also embedded on golang.org.
This change caused those links to point to
https://golang.org/go2-here-we-come, which is 404.

Fixes golang/go#36930
Updates golang/go#36944

Change-Id: Ie5ca8f112ff6465328d258b283d540c07e909a54
Reviewed-on: https://go-review.googlesource.com/c/blog/+/217239
Reviewed-by: Robert Griesemer <gri@golang.org>
X-Blog-Commit: e1c854a5c639de192ed53c9fb8059c6be190b182
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
[x/blog] content/go1.15-proposals.article: revert "use relative links…
f6428ce 
… for other blog articles"

This reverts CL 216626 (commit 8bf1296992b6579acabcba62cc6cd0efe039c38a).

We cannot rely on relative links in blog posts to stay relative to
blog.golang.org, because blog posts are also embedded on golang.org.
This change caused those links to point to
https://golang.org/go2-here-we-come, which is 404.

Fixes golang/go#36930
Updates golang/go#36944

Change-Id: Ie5ca8f112ff6465328d258b283d540c07e909a54
Reviewed-on: https://go-review.googlesource.com/c/blog/+/217239
Reviewed-by: Robert Griesemer <gri@golang.org>
X-Blog-Commit: e1c854a5c639de192ed53c9fb8059c6be190b182
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @s-chand @ALTree @gopherbot