Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: accept * as URI in request parser #3692

Closed
anacrolix opened this issue Jun 1, 2012 · 7 comments
Closed

net/http: accept * as URI in request parser #3692

anacrolix opened this issue Jun 1, 2012 · 7 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Go1.1

Comments

@anacrolix
Copy link
Contributor 

Before filing a bug, please check whether it has been fixed since the
latest release. Search the issue tracker and check that you're running the
latest version of Go:

Run "go version" and compare against
http://golang.org/doc/devel/release.html  If a newer version of Go exists,
install it and retry what you did to reproduce the problem.

Thanks.

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1. Parse a HTTP request with an unusual URL, such as SSDP notification.
2. Parsing fails because the rawurl is "*"

What is the expected output?
The request URL should be set to nil, and "*" be present in
http.Request.RequestURI.


What do you see instead?
A parse error.

Which version are you using?  (run 'go version')
go1

Please provide any additional information below.
I can provide a patch.
@robpike
Copy link
Contributor

robpike commented Jun 1, 2012

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Owner changed to builder@golang.org.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Sep 12, 2012

Comment 3:

Labels changed: added go1.1.

@bradfitz
Copy link
Contributor

Comment 4:

I think the Students for Sensible Drug Policy can make their own package.  The HTTP
package shouldn't be expected to speak every protocol.
But if this bug is just about accepting "*", that's more reasonable, because that
appears in HTTP.

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 6:

Labels changed: added size-m.

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 7:

Labels changed: added suggested.

@bradfitz
Copy link
Contributor

Comment 8:

Sent https://golang.org/cl/6868095/

Owner changed to @bradfitz.

Status changed to Started.

@bradfitz
Copy link
Contributor

Comment 9:

This issue was closed by revision a6701f2.

Status changed to Fixed.

@anacrolix anacrolix added fixed Suggested Issues that may be good for new contributors looking for work to do. labels Dec 11, 2012
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
5 participants
@bradfitz @rsc @anacrolix @robpike @gopherbot