Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: references fails with 'no identifier found' #36917

Closed
stamblerre opened this issue Jan 31, 2020 · 4 comments
Closed

x/tools/gopls: references fails with 'no identifier found' #36917

stamblerre opened this issue Jan 31, 2020 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.0

Comments

@stamblerre
Copy link
Contributor

Filing this now so I don't forget, but the repro case won't be great. I was working in golang.org/x/tools/internal/lsp/cache package in golang.org/x/tools/internal/lsp/cache/snapshot.go. I did find references on a field of snapshot, specifically on s.ids. It works fine if you run find references from the definition of the field, but it failed when I called it on a use of the field.

/cc @muirdm
@stamblerre stamblerre added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 31, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jan 31, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 31, 2020
@muirdm
Copy link

muirdm commented Jan 31, 2020

On first attempt I can't reproduce anything like that. no identifier found means we didn't find an *ast.Ident at the requested position. Maybe you had a syntax error that was messing up the AST, or maybe content was out of sync somehow? Can you reproduce it?

@stamblerre
Copy link
Contributor Author

stamblerre commented Jan 31, 2020 •
edited

Ah yes - just realized what it was! It was a map lookup - s.ids[uri]. I am able to consistently reproduce it.

@stamblerre
Copy link
Contributor Author

The issue seems to exist only on master, not on gopls/v0.3.0-pre3.

@stamblerre
Copy link
Contributor Author

I'm so sorry for the bother - it was my own CL that's causing it. I'll investigate why it's happening.

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.4.0 Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.0
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @muirdm