Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: TestOverlayDeps extremely flaky at head #36908

Closed
bcmills opened this issue Jan 30, 2020 · 4 comments
Closed

x/tools/go/packages: TestOverlayDeps extremely flaky at head #36908

bcmills opened this issue Jan 30, 2020 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 30, 2020

From https://build.golang.org/log/7744d28fa4375e496b89bde4e1a7b25775de06cd (and many others):

--- FAIL: TestOverlayDeps (1.88s)
    --- FAIL: TestOverlayDeps/GOPATH (0.88s)
        packages_test.go:1000: expected net/http import in golang.org/fake/c [golang.org/fake/c.test]
    --- FAIL: TestOverlayDeps/Modules (1.00s)
        packages_test.go:1000: expected net/http import in golang.org/fake/c [golang.org/fake/c.test]
FAIL
FAIL	golang.org/x/tools/go/packages	62.244s

The failures seem to have started as of CL 216721.

CC @jayconrod
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Jan 30, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jan 30, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 30, 2020
@matloob
Copy link
Contributor

matloob commented Jan 30, 2020

Looking at this now

@gopherbot
Copy link

Change https://golang.org/cl/217084 mentions this issue: go/packages: make TestOverlayDeps deterministic

@matloob
Copy link
Contributor

matloob commented Jan 30, 2020

I have no idea how the failure could be related to that CL.

@gopherbot
Copy link

Change https://golang.org/cl/217087 mentions this issue: go/packages: fix non-determinism on package list order

gopherbot pushed a commit to golang/tools that referenced this issue Jan 30, 2020
@matloob
go/packages: fix non-determinism on package list order
fe90550 
Even though users shouldn't depend on the order of the package list,
go/packages.Load should still return packages in a deterministic order.
golang.org/cl/216721 broke the determinism by getting package
order using a map. Fix that by sorting the packages.

Updates golang/go#36908

Change-Id: Icf8476009abfc27009d494eb57712caeb0775343
Reviewed-on: https://go-review.googlesource.com/c/tools/+/217087
Run-TryBot: Michael Matloob <matloob@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Jan 29, 2021
@rsc rsc unassigned matloob Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @matloob