New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: support case insensitive file systems #36904
Comments
Change https://golang.org/cl/217080 mentions this issue: |
Drive letters are always case-insensitive, so we should standardize them by always keeping them uppercase. Updates golang/go#36904 Change-Id: I8de25b175790b01627f947600c1511edf38c316c Reviewed-on: https://go-review.googlesource.com/c/tools/+/217080 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
Change https://golang.org/cl/217088 mentions this issue: |
Drive letters are always case-insensitive, so we should standardize them by always keeping them uppercase. Updates golang/go#36904 Change-Id: I8de25b175790b01627f947600c1511edf38c316c Reviewed-on: https://go-review.googlesource.com/c/tools/+/217080 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> (cherry picked from commit 0725381) Reviewed-on: https://go-review.googlesource.com/c/tools/+/217088 Reviewed-by: Michael Matloob <matloob@golang.org>
@heschik: Do you think there is anything else we can do here to handle case insensitive file systems, or can we close this issue? |
There might be other stuff we can do but in general I would hope that everything would be case-preserving and it wouldn't matter. I say close. |
We have a report on Slack of VS Code using the wrong case for |
As I mentioned in Slack, I'm not sure if this is a VSCode or gopls issue. Somehow VSCode opened the folder
|
Change https://golang.org/cl/225239 mentions this issue: |
On case-insensitive file systems, the editor may send us a path that works but doesn't match the actual file's case. Then when we run go list, we'll get mismatching paths and everything will break. We can't reliably fix this problem: tracking what case the editor expects is too difficult to be worth it. Instead, check the workspace path and bail if it's mismatched. Possibly we should also check files on DidOpen or such, but we can start with this. Updates golang/go#36904. Change-Id: I7635c8136bf9400db4143a0f2fde25c39b5abc44 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225239 Reviewed-by: Ian Cottrell <iancottrell@google.com>
@heschik: Is there any more work to do for this issue? |
Check it on file open? But we can wait for the next complaint if any. |
gopls
doesn't support case-insensitive file systems. VS Code always sends lower-case drive letters, but if a user sets their GOPATH toC://bob/go
,go list
will return upper-case drive letters. At that point,gopls
will think it did not get metadata for the given file, and it will not work correctly.The text was updated successfully, but these errors were encountered: