Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/expect: add better marker support for // indirect in go.mod files #36894

Open
ridersofrohan opened this issue Jan 30, 2020 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@ridersofrohan
Copy link

ridersofrohan commented Jan 30, 2020

Currently in go/expect when a user wants to add a marker for go.mod files, we have a special case if they are trying to mark // indirect:

//@mark(IndirectMarker, "// indirect")
require golang.org/x/tools v0.0.0-20191219192050-56b0b28a00f7 // indirect

This is a little confusing and is the only case where the marker has to be on the line above. As a result, there should be a better way to do this that is more intuitive that does not require having a special case just for this.

This issue is an extension of #36091

/cc @stamblerre @ianthehat

@ridersofrohan ridersofrohan added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 30, 2020
@stamblerre stamblerre changed the title go/expect: for go.mod files add better marker support for // indirect go/expect: add better marker support for // indirect in go.mod files Jan 30, 2020
@stamblerre stamblerre changed the title go/expect: add better marker support for // indirect in go.mod files x/tools/go/expect: add better marker support for // indirect in go.mod files Jan 30, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jan 30, 2020
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants