Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: detect pseudoversions in gopls version #36847

Closed
stamblerre opened this issue Jan 28, 2020 · 3 comments
Closed

x/tools/gopls: detect pseudoversions in gopls version #36847

stamblerre opened this issue Jan 28, 2020 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.0

Comments

@stamblerre
Copy link
Contributor

We originally started tagging releases on master, which means that gopls@master reports its version as a pseudoversion starting with v0.1.8 (the last tag on master). This is misleading for users, at it makes its seem that master is behind latest. We should instead detect the pseudoversion and output something else when the user is at master.
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jan 28, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 28, 2020
@bcmills
Copy link
Contributor

bcmills commented Jan 28, 2020 •
edited

Better still, add some pre-release tags on the master branch.

(For example, you could tag the first commit after gopls-release-branch.0.2 was cut as gopls/v0.3.0-dev so that all of the pseudo-versions from that point sort as pre-releases for v0.3.0.)

@stamblerre
Copy link
Contributor Author

We've come to the realization that we probably won't be principled about tagging pre-release tags on master, and with that approach, the automatic version detection in VS Code version won't work for users that opt-into pre-releases. As an alternative, we're considering deleting all of the tags on master so that the pseudoversion appears as v0.0.0. This will have the effect of invalidating those pre-existing pseudoversions, which we've concluded is fine since they are old anyway and no one should depend on the gopls module.

@stamblerre
Copy link
Contributor Author

We have since deleted all of the tags that were created on the master branch. Closing.

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.4.0 Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.0
Development

No branches or pull requests
3 participants
@bcmills @stamblerre @gopherbot