New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: floating-point broken on android-arm-corellium builder #36830
Comments
@benshi001 Ben, can you take a look? |
Seems to be failing for GOARCH=arm GOARM=6. GOARM=7 is also broken. GOARM=5 is fine.
|
Here's a simple reproducer:
Compile this with GOARCH=arm GOARM=7, copy to builder, and run it. We get:
Something is seriously wrong with the floating point comparison hardware on this machine. The code for
|
... or maybe the OS isn't saving/restoring floating point comparison flags? That would explain the erraticness... |
Seems to be all the comparisons, occasionally.
|
Same behavior for the compare-with-zero instruction, and for float64. |
Does it work if we disable async preemption? GODEBUG=asyncpreemptoff=1 |
GOARM=5 implies softfloat. I don't think android-arm is a softfloat builder. But we do have some softfloat tests that runs everywhere. The arm5 builder is a softfloat builder (and the only one). |
Still buggy with that set. Same with GOGC=off. arm64 binaries on the same machine work fine. |
Thanks. So it is probably indeed a hardware/OS bug... |
I can reproduce with C.
Note that it fails when compiled with Anyone know how to contact Corellium and file a bug? Their website is not very helpful. |
cc @eliasnaur |
I got in contact with the Corellium folks and they've opened an internal issue for it. Likely it will be fixed in their next release, eta unknown. |
Looks like this was fixed by an update on Corellium's part on our about 2/17. |
Seems to have started after Jan. 19.
Have there been recent changes in this builder image or configuration? Otherwise, the only major changes over that interval have been @4a6f656c's RISC-V changes.
CC @cagedmantis @dmitshur @toothrot @Zenly
2020-01-28T02:40:44-a858d15/android-arm-corellium
2020-01-28T02:39:28-d8e0526/android-arm-corellium
2020-01-27T23:23:00-22f09ce/android-arm-corellium
2020-01-27T20:45:39-74d366f/android-arm-corellium
2020-01-27T14:34:16-4615b39/android-arm-corellium
2020-01-25T16:34:18-73d2137/android-arm-corellium
2020-01-24T19:19:16-e35876e/android-arm-corellium
2020-01-24T17:36:44-1f9f88b/android-arm-corellium
2020-01-23T23:07:10-8d7be1e/android-arm-corellium
2020-01-23T21:01:12-ace25f8/android-arm-corellium
2020-01-23T20:44:44-8453844/android-arm-corellium
2020-01-23T19:11:41-39ea3d0/android-arm-corellium
2020-01-23T16:52:00-64378c2/android-arm-corellium
2020-01-23T07:39:53-9f07cdd/android-arm-corellium
2020-01-22T18:10:42-895b7c8/android-arm-corellium
2020-01-22T15:24:05-6718cb6/android-arm-corellium
The text was updated successfully, but these errors were encountered: