Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: keyboard shortcut '/' should focus the search box #36805

Closed
myitcv opened this issue Jan 27, 2020 · 4 comments
Closed

x/pkgsite: keyboard shortcut '/' should focus the search box #36805

myitcv opened this issue Jan 27, 2020 · 4 comments
Labels
FeatureRequest FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unreleased

Comments

@myitcv
Copy link
Member

myitcv commented Jan 27, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/govim/govim?tab=doc

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.66 Safari/537.36

Screenshot

Screen Shot 2020-01-27 at 18 55 20

What did you do?

Tried to focus the search input box using /

What did you expect to see?

Focus shifting to the search box

What did you see instead?

Nothing happened.

This was a useful feature of godoc, e.g. try that keyboard shortcut on https://godoc.org/github.com/govim/govim

Screen Shot 2020-01-27 at 18 55 45
@myitcv myitcv added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Jan 27, 2020
@gopherbot gopherbot added this to the Unreleased milestone Feb 6, 2020
@julieqiu julieqiu added the UX Issues that involve UXD/UXR input label Feb 28, 2020
@julieqiu julieqiu changed the title go.dev: keyboard shortcut '/' should focus the search box x/pkgsite: keyboard shortcut '/' should focus the search box Jun 15, 2020
@julieqiu julieqiu added help wanted Suggested Issues that may be good for new contributors looking for work to do. and removed UX Issues that involve UXD/UXR input labels Jun 15, 2020
@kush-patel-hs
Copy link
Contributor

Sounds like a useful feature :) I will add

@kush-patel-hs
Copy link
Contributor

jump.js is becoming more like keyboard_shortcuts.js https://go-review.googlesource.com/c/pkgsite/+/240297, but this should do it! Open to suggestions. It is working locally for me.

@gopherbot
Copy link

Change https://golang.org/cl/240297 mentions this issue: content/static: add keyboard shortcut '/' to focus search box

@zombiezen
Copy link
Contributor

This appears to have regressed with the new left sidebar UI change.

@julieqiu julieqiu mentioned this issue Nov 30, 2020
Closed
@golang golang locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@zombiezen @myitcv @julieqiu @gopherbot @kush-patel-hs