x/tools/gopls: inconsistent behaviour with GOFLAGS=-mod=readonly set #36789
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
WaitingForInfo
Issue is not actionable because of missing required information, which needs to be provided.
Milestone
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
We have a
govim
test that verifies the setting of the"env"
valueGOFLAG=-mod=readonly
. It is based on the following setup:(
example.com/blah
is a valid module and is accessible).We initially verify that we have the following diagnostic:
However we often (~50% of the time, which is actually 100% of the time on CI, I can't reproduce locally) do not receive this diagnostic.
The following errors are logged by
gopls
:What's interesting is that when this test passes we do not see this or any errors logged by
gopls
.Given I can't repro this locally it suggests there's an element of timing involved.
What did you expect to see?
Consistently receiving an initial diagnostic from
gopls
formain.go
What did you see instead?
As above.
gopls
log for failing test: fail.loggopls
log for passing test: pass.logMarking as
v1.0.0
because this isn't critical forv0.3.0
to my mind.cc @stamblerre
FYI @leitzler
The text was updated successfully, but these errors were encountered: