Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: use Stmt.NumInput in DB.Exec #3678

Closed
alexbrainman opened this issue May 29, 2012 · 6 comments
Closed

database/sql: use Stmt.NumInput in DB.Exec #3678

alexbrainman opened this issue May 29, 2012 · 6 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Go1.1

Comments

@alexbrainman
Copy link
Member 

It seems, that (*DB).Query, (s *Stmt).Exec and (s *Stmt).Query all use
database/sql/driver/Stmt.NumInput to verify number of parameters. But (*DB).Exec does
not.

Alex
@robpike
Copy link
Contributor

robpike commented Jun 1, 2012

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Sep 12, 2012

Comment 3:

Labels changed: added go1.1.

@bradfitz
Copy link
Contributor

Comment 4:

https://golang.org/cl/6460087/

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 5:

Labels changed: added size-m.

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 6:

Labels changed: added suggested.

@bradfitz
Copy link
Contributor

Comment 7:

This issue was closed by revision 7f0449a.

Status changed to Fixed.

@alexbrainman alexbrainman added fixed Suggested Issues that may be good for new contributors looking for work to do. labels Jan 11, 2013
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
5 participants
@bradfitz @rsc @robpike @gopherbot @alexbrainman