Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strconv: QuoteToGraphic documentation on ASCII is wrong #36778

Closed
pascaldekloe opened this issue Jan 26, 2020 · 2 comments · Fixed by sthagen/golang-go#132
Closed

strconv: QuoteToGraphic documentation on ASCII is wrong #36778

pascaldekloe opened this issue Jan 26, 2020 · 2 comments · Fixed by sthagen/golang-go#132

Comments

@pascaldekloe
Copy link
Contributor

QuoteToGraphic returns a double-quoted Go string literal representing s. The returned string uses Go escape sequences (\t, \n, \xFF, \u0100) for non-ASCII characters and non-printable characters as defined by IsGraphic.

The documentation reads like non-ASCII characters are escaped, and they are not. I'm not even sure that the mention of ASCII was ment to say here.

@gopherbot
Copy link

Change https://golang.org/cl/216478 mentions this issue: strconv: stop describing Unicode graphic characters as non-ASCII

@pascaldekloe
Copy link
Contributor Author

Thanks @ianlancetaylor.

gopherbot pushed a commit that referenced this issue Jan 26, 2020
Fixes #36778

Change-Id: I3c4ce100fc219bda0ff1d7a086c2309ed695691d
Reviewed-on: https://go-review.googlesource.com/c/go/+/216478
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
@golang golang locked and limited conversation to collaborators Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants