Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: incorrect active parameter for signature help #36766

Closed
stamblerre opened this issue Jan 25, 2020 · 2 comments
Closed

x/tools/gopls: incorrect active parameter for signature help #36766

stamblerre opened this issue Jan 25, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.0

Comments

@stamblerre
Copy link
Contributor

Borrowing the repro from saibing/bingo#20:

package main

func foo(a, b int) int {
	return 42
}

func main() {
	foo(<>
}

Looks like we return b as the active parameter instead of a when signature help is triggered at the marked position.
@gopherbot gopherbot added this to the Unreleased milestone Jan 25, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 25, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Jan 25, 2020
@stamblerre stamblerre mentioned this issue Jan 25, 2020
Open
@oblitum
Copy link

oblitum commented Jan 25, 2020 •
edited

Notice that the issue does not happen when the parentheses pair is expanded by snippet. To trigger the problem it's needed to type opening parentheses. It happens when it's left open and there isn't a closing one.

@gopherbot
Copy link

Change https://golang.org/cl/216309 mentions this issue: internal/lsp: fix active parameter for incomplete parentheses

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.4.0 Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.0
Development

No branches or pull requests
3 participants
@oblitum @stamblerre @gopherbot