Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: get more coverage with the ssacheck builder #36756

Open
josharian opened this issue Jan 24, 2020 · 1 comment
Open

x/build: get more coverage with the ssacheck builder #36756

josharian opened this issue Jan 24, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@josharian
Copy link
Contributor

The ssacheck builder currently builds only amd64, and with a fixed random seed.

We should improve on both dimensions.

  • CL 216418 lets us provide a random seed. We could generate the random seed and print it to stdout before using it, so that any failure will be reproducible from the log.
  • We should either run on all architectures, or pick one at random each time from go tool dist list (and log it, for reproducibility).

I suspect that doing both of these things is pretty easy, and it'd get us extra test coverage, so it'd be nice to do soon. This would have caught both #36723 and #36755.

cc @cherrymui @randall77 @dmitshur @bradfitz
@gopherbot gopherbot added this to the Unreleased milestone Jan 24, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 24, 2020
@josharian josharian mentioned this issue Jan 24, 2020
Closed
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 24, 2020
This was referenced May 5, 2020
Closed
Closed
@josharian
Copy link
Contributor Author

Another this would have caught: #38880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@toothrot @josharian @gopherbot