Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: adding a test causes overlay errors to linger #36754

Closed
stamblerre opened this issue Jan 24, 2020 · 1 comment
Closed

x/tools/gopls: adding a test causes overlay errors to linger #36754

stamblerre opened this issue Jan 24, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.3.0

Comments

@stamblerre
Copy link
Contributor

The example given in #36635 mostly works now, but the go list error about the overlay seems to come back as a diagnostic. We shouldn't show that error.
@stamblerre stamblerre added this to the gopls/v0.3.0 milestone Jan 24, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 24, 2020
@gopherbot
Copy link

Change https://golang.org/cl/216310 mentions this issue: internal/lsp: don't show list errors unless necessary

@golang golang locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.3.0
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot