New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/x509: MarshalPKCS8PrivateKey doc says RSA private key while it supports more than that #36735
Comments
Yep that just looks like a typo to me. I'd be happy to patch that. @FiloSottile do you agree that this is a bug? |
Yep, it's a typo. Go ahead! |
Change https://golang.org/cl/217917 mentions this issue: |
@gopherbot please backport to 1.13 and 1.14 |
Backport issue(s) opened: #37067 (for 1.13), #37068 (for 1.14). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases. |
Change https://golang.org/cl/217998 mentions this issue: |
Change https://golang.org/cl/217999 mentions this issue: |
…eKey Updates #36735 Fixes #37067 Change-Id: I93f005d78f4bfac773272995b165172461bae92f Reviewed-on: https://go-review.googlesource.com/c/go/+/217917 Run-TryBot: Katie Hockman <katie@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org> (cherry picked from commit 7a36fa4) Reviewed-on: https://go-review.googlesource.com/c/go/+/217998
…eKey Updates #36735 Fixes #37068 Change-Id: I93f005d78f4bfac773272995b165172461bae92f Reviewed-on: https://go-review.googlesource.com/c/go/+/217917 Run-TryBot: Katie Hockman <katie@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org> (cherry picked from commit 7a36fa4) Reviewed-on: https://go-review.googlesource.com/c/go/+/217999
Doc of
x509.MarshalPKCS8PrivateKey
says:But immediately after doc says that it also supports ECDSA and ED25519 key types:
I think that the "RSA" word in first line should be removed.
If this is confirmed, I can take care of this doc fix.
The text was updated successfully, but these errors were encountered: