Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: cmd/gitmirror not mirroring proposal repository #36682

Closed
ianlancetaylor opened this issue Jan 21, 2020 · 4 comments
Closed

x/build: cmd/gitmirror not mirroring proposal repository #36682

ianlancetaylor opened this issue Jan 21, 2020 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@ianlancetaylor
Copy link
Contributor

The most recent changes to https://go.googlesource.com/proposal are not being mirrored to https://github.com/golang/proposal. The latest change on the latter is from October 23, 2019. The lasest change on the former is from today (January 21, 2020).

CC @toothrot @dmitshur
@gopherbot gopherbot added this to the Unreleased milestone Jan 21, 2020
@ianlancetaylor ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 21, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 21, 2020
@dmitshur
Copy link
Contributor

Looking. farmer.golang.org is currently reporting that gitmirror status is "ok". Something must be wrong.

@dmitshur
Copy link
Contributor

From logs:

2020/01/17 18:02:20 Not mirroring repo proposal

This might be a misconfiguration.

@dmitshur dmitshur self-assigned this Jan 21, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Jan 21, 2020 •
edited

More repos that aren't being mirrored from logs:

2020/01/17 18:02:20 Not mirroring repo grpc-review
2020/01/17 18:02:20 Not mirroring repo gollvm
2020/01/17 18:02:20 Not mirroring repo sublime-build
2020/01/17 18:02:20 Not mirroring repo proposal
2020/01/17 18:02:20 Not mirroring repo sublime-config

However, they should be mirrored per https://github.com/golang/build/blob/d3fb66653c7bebb6834247367b68f647100d98b5/repos/repos.go#L55-L58.

cmd/gitmirror was last deployed 46 days ago. I think it just needs to be redeployed to pick up the changes from CL 210461 where "proposal" and other repos were added to be mirrored. /cc @bradfitz

I'll do that now.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 21, 2020
@dmitshur
Copy link
Contributor

After redeploying:

2020/01/21 22:42:43 Not mirroring repo grpc-review
2020/01/21 22:42:43 Not mirroring repo gollvm

This is consistent with the configuration in the latest version of the golang.org/x/build/repos package (see here).

The proposal, sublime-build, and sublime-config repos should be mirrored now. I'll close this as resolved, but please let me know if there's anything more to do here.

@golang golang locked and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @ianlancetaylor @gopherbot