New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: scenario_completeunimported/complete_new_file (govim) test flaky #36671
Comments
Change https://golang.org/cl/215681 mentions this issue: |
Re-opening because we're seeing some flakey behaviour here. About 20% of the time in We are seeing these failures again 8fe064f. The test fails in exactly the same way described above. The |
Similarly, as on #36661, would it be possible to generate a log with |
Here you go: gopls.log |
This also looks like another case where we're failing to load the package correctly - it's being loaded ad-hoc, which is why you see the "command-line-arguments" package path. Is there a |
Yes, this is a |
I am not able to reproduce this test failure locally with https://golang.org/cl/216637. |
Change https://golang.org/cl/216637 mentions this issue: |
Thanks - the changes in that CL (and other CLs) do appear to fix this issue. I'll leave this open and let the submitting of that CL close this. |
If an orphaned file is used to recover a workspace package, we should remove the initialization error and treat the view as correctly initialized. Also, stop caching metadata for packages with no files. We have no way to invalidate it, and it's useless, so just re-load those files as needed. Fixes golang/go#36795. Fixes golang/go#36671. Fixes golang/go#36772. Change-Id: I0aee5a43401517b6073d27136cca533160effef2
What version of Go are you using (
go version
)?Note that per govim/govim@c7a6cc3,
github.com/myitcvforks/tools/gopls@v0.0.0-20200119092928-0fd5434cd1ba
is 0cba7a3 with a partial revert of CL214586 on top (the result of which can be seen in https://go-review.googlesource.com/c/tools/+/215239)The issue described below also exists when tested against 0cba7a3.
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
As part of govim/govim#699 we are adding some tests that verify
gopls
behaviour with files that are not saved on disk.One of these tests is for unimported completions.
The sequence is:
Attempt a completion on line 4 with
fmt.Pr
What did you expect to see?
Expected candidates to include
fmt.Println
What did you see instead?
No completion candidates.
gopls
log file: gopls.logcc @stamblerre @muirdm @heschik
FYI @leitzler
The text was updated successfully, but these errors were encountered: