Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: cannot regenerate rules files using non-tip compiler #36663

Closed
josharian opened this issue Jan 21, 2020 · 4 comments
Closed

cmd/compile: cannot regenerate rules files using non-tip compiler #36663

josharian opened this issue Jan 21, 2020 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.14

Comments

@josharian
Copy link
Contributor

Until recently, it was possible to use a non-tip compiler to regenerate the rules files. This is important, since it (a) prevents you from needing tip to compile to regenerate rules and (b) allows you to use a stable compiler.

That no longer works. Using 1.13 I get:

$ go run *.go
build command-line-arguments: cannot load cmd/internal/obj/riscv: package cmd/internal/obj/riscv is not in GOROOT (/Users/josh/go/1.13/src/cmd/internal/obj/riscv)

Using 1.14 beta 1, I get:

$ go run *.go
RISCV64Ops.go:9:8: use of internal package cmd/internal/obj/riscv not allowed

cc @randall77 @4a6f656c
@toothrot toothrot added this to the Backlog milestone Jan 21, 2020
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 21, 2020
@4a6f656c
Copy link
Contributor

@josharian - I guess we'll just have to duplicate the register names and numbers, like the other platforms do...

@josharian
Copy link
Contributor Author

@4a6f656c yes. unfortunate, but there you are.

@josharian
Copy link
Contributor Author

I'd really like this to get fixed soon. It is a serious annoyance when working on rules.

@josharian josharian modified the milestones: Backlog, Go1.14 Jan 25, 2020
@gopherbot
Copy link

Change https://golang.org/cl/216518 mentions this issue: cmd/compile/internal/ssa/gen: avoid importing internal riscv64 packages

@golang golang locked and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
4 participants
@toothrot @josharian @4a6f656c @gopherbot