Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/dist: cmd/internal/objabi/zbootstrap.go is not removed #36660

Open
perillo opened this issue Jan 20, 2020 · 5 comments
Open

cmd/dist: cmd/internal/objabi/zbootstrap.go is not removed #36660

perillo opened this issue Jan 20, 2020 · 5 comments
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@perillo
Copy link
Contributor

perillo commented Jan 20, 2020

I noted that on Linux amd64, with go1.14beta1-137-g71239b4f49, after calling make.bash, clean.bash does not remove the file cmd/internal/objabi/zbootstrap.go.

I have confirmed the problem using git status --ignored.
@toothrot toothrot changed the title clean.bash: cmd/internal/objabi/zbootstrap.go is not removed cmd/dist: cmd/internal/objabi/zbootstrap.go is not removed Jan 21, 2020
@toothrot
Copy link
Contributor

toothrot commented Jan 21, 2020 •
edited

I think that is supposed to be cleaned up by go tool dist clean, but I am not positive.

/cc @bcmills @jayconrod

@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 21, 2020
@toothrot toothrot added this to the Backlog milestone Jan 21, 2020
@ianlancetaylor
Copy link
Contributor

I bet that "cmd/internal/objabi" should be added to cleanlist in cmd/dist/build.go.

@SataQiu
Copy link
Contributor

SataQiu commented Jan 24, 2020

I'm willing to have a try!

@SataQiu SataQiu mentioned this issue Jan 24, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/216222 mentions this issue: cmd/dist: fix the bug that cmd/internal/objabi/zbootstrap.go could not be cleaned properly

@perillo
Copy link
Contributor Author

perillo commented Jan 24, 2020

@SataQiu I suggest to change the commit message to
cmd/dist: ensure that cmd/internal/objabi/zbootstrap.go is cleaned properly

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

cmd/dist: ensure that cmd/internal/objabi/zbootstrap.go is cleaned properly SataQiu/go
6 participants
@toothrot @ianlancetaylor @bcmills @perillo @gopherbot @SataQiu