New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: set prologue_end on every arch #36612
Comments
https://golang.org/cl/223297 did part of this. Any more planned for 1.15? |
...though that CL isn't merged yet. |
Any time you want to +2 it.... |
The CL got merged on May 13th aka 16 days ago. @dr2chase I shall move this to Go1.16 then. |
I'm okay with go1.16. Part of the problem is knowing exactly what's right; because of better-user-experience issues, Delve wants it to be someplace that apparently doesn't match what gdb would expect. (My personal user experience with gdb is so terrible that I would never recommend it to a Go user.) |
This patch adds a prologue_end statement to the DWARF information for the ppc64 arch. Prologue end is used by the Delve debugger in order to determine where to set a breakpoint to avoid the stacksplit prologue. Updates golang#36612
Change https://golang.org/cl/266019 mentions this issue: |
This patch adds a prologue_end statement to the DWARF information for the ppc64 arch. Prologue end is used by the Delve debugger in order to determine where to set a breakpoint to avoid the stacksplit prologue. Updates #36612 Change-Id: Ifb16c1476fe716a0bf493c5486d1d88ebe8d0253 GitHub-Last-Rev: 77a2172 GitHub-Pull-Request: #42261 Reviewed-on: https://go-review.googlesource.com/c/go/+/266019 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: Alessandro Arzilli <alessandro.arzilli@gmail.com> Trust: Dmitri Shuralyov <dmitshur@golang.org>
@dr2chase , what's the current status of this? Are you planning to do any more on this for 1.16 or should we bump it to 1.17? |
Derek Parker (i.e., Delve developers) recently added ppc64. One reason to wait on demand from Delve is that ensures we do it the way they want, instead of accidentally picking wrong and then someone else depends on that choice. |
Moving to Backlog. |
As of Go 1.11 and commit 7bac2a9 support was added to put information about the end of the function prologue into the produced DWARF information, however it currently only works for x86.
Ideally the DWARF information produced is consistent across arches. In Delve if this information is not present we have to disassemble the function in order to pattern match known function prologues in order to skip them. This is undesirable to say the least and I would like to delete that code.
Opening this issue to track adding prologue_end to the DWARF information produced on every arch.
The text was updated successfully, but these errors were encountered: