Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: removing an import should modify metadata #36607

Closed
stamblerre opened this issue Jan 16, 2020 · 1 comment
Closed

x/tools/gopls: removing an import should modify metadata #36607

stamblerre opened this issue Jan 16, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.3.0

Comments

@stamblerre
Copy link
Contributor

Right now, we do not reload metadata if a user removes an import, since that technically doesn't require additional data. However, we should still make the relevant modifications in the metadata tree, so that reverse dependencies can be computed correctly and diagnostics can be shown correctly.
@gopherbot gopherbot added this to the Unreleased milestone Jan 16, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 16, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.3.0 Jan 16, 2020
@gopherbot gopherbot modified the milestones: gopls/v0.3.0, Unreleased Jan 16, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.3.0 Jan 17, 2020
@stamblerre
Copy link
Contributor Author

Closing this because it's not actually true. go/types will handle raising diagnostic errors when we remove an import.

@golang golang locked and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.3.0
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot