Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress/flate: index out of range panic #3660

Closed
alberts opened this issue May 22, 2012 · 9 comments
Closed

compress/flate: index out of range panic #3660

alberts opened this issue May 22, 2012 · 9 comments

Comments

@alberts
Copy link
Contributor

alberts commented May 22, 2012

What steps will reproduce the problem?

Don't know quite how to reproduce this but it seems to happen when deflating a tarball
we are creating using archive/tar to contain about 6 log files each of about 500 MB in
size. Maybe we are hitting some kind of 2 GB limit somewhere?

What do you see instead?

top of stack:

compress/flate.(*compressor).findMatch(0xf84153f0b0, 0x7fd87fff0000aa57, 0x55a900000002,
0x2, 0x0, ...)
go/src/pkg/compress/flate/deflate.go:157 +0x10e
compress/flate.(*compressor).deflate(0xf84153f0b0, 0xf8b5181e00)
go/src/pkg/compress/flate/deflate.go:266 +0x413
compress/flate.(*compressor).write(0xf84153f0b0, 0xf8b5189e00, 0x199a51a5199a51a5,
0xf81d25afa5, 0x0, ...)
go/src/pkg/compress/flate/deflate.go:359 +0xa0
compress/flate.(*Writer).Write(0xf84153f0b0, 0xf8b18d4000, 0x1d25afa51d25afa5,
0xf91d25afa5, 0x0, ...)
go/src/pkg/compress/flate/deflate.go:469 +0x54
compress/gzip.(*Writer).Write(0xf840112f20, 0xf8b18d4000, 0x1d25afa51d25afa5,
0xf929745094, 0x16c00000007, ...)
go/src/pkg/compress/gzip/gzip.go:190 +0x56c
archive/tar.(*Writer).Write(0xf8400a3f80, 0xf8b18d4000, 0x1d25afa51d25afa5, 0x0, 0x0,
...)
go/src/pkg/archive/tar/writer.go:184 +0xc7

Which compiler are you using (5g, 6g, 8g, gccgo)?

6g

Which operating system are you using?

linux

Which version are you using?  (run 'go version')

revision 8db1b9223486

Please provide any additional information below.
@alberts
Copy link
Contributor Author

alberts commented May 22, 2012

Comment 1:

the panic is
panic: runtime error: index out of range
of course

@rsc
Copy link
Contributor

rsc commented May 22, 2012

Comment 2:

This isn't much to go on.  Please try to reproduce with data you can share.
Russ

Status changed to WaitingForReply.

@alberts
Copy link
Contributor Author

alberts commented May 22, 2012

Comment 3:

Will do. Make take a few days.

@krasin
Copy link

krasin commented May 30, 2012

Comment 4:

Is it a duplicate of 3676?

@rsc
Copy link
Contributor

rsc commented May 30, 2012

Comment 5:

Probably, but 3676 has an actual data file.
I tried with random input and that was not good enough.
Russ

@alberts
Copy link
Contributor Author

alberts commented May 30, 2012

Comment 6:

Once the fix for 3676 is in, I will test it with the kind of data that produced this
panic for us.

@davecheney
Copy link
Contributor

Comment 7:

fullung, the fix was committed in 
http://code.google.com/p/go/source/detail?r=00a1ca1ea3bd, can you please check and let
us know if this issue was closed.

@alberts
Copy link
Contributor Author

alberts commented Jun 4, 2012

Comment 8:

looks fixed. thanks.

@rsc
Copy link
Contributor

rsc commented Jun 4, 2012

Comment 9:

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants