Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/sha3: add tests with assembly disabled #36466

Open
mundaym opened this issue Jan 8, 2020 · 1 comment
Open

x/crypto/sha3: add tests with assembly disabled #36466

mundaym opened this issue Jan 8, 2020 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@mundaym
Copy link
Member

mundaym commented Jan 8, 2020

Both amd64 and s390x have assembly implementations of SHA-3. On amd64 the assembly is always used and the generic implementation is not tested at all. On s390x the generic implementation won't be tested if the SHA-3 CPU features are available. On both platforms we should add tests for the generic code to ensure it is properly tested.

Unfortunately due to the nature of the instructions involved they are implemented in different ways so this will take some thinking.
@mundaym mundaym added this to the Unreleased milestone Jan 8, 2020
@mundaym mundaym self-assigned this Jan 8, 2020
@FiloSottile
Copy link
Contributor

See https://golang.org/wiki/TargetSpecific.

@rsc rsc unassigned mundaym Jun 23, 2022
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@cagedmantis @FiloSottile @mundaym