Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: racing write to t.ProxyConnectHeader in dialConn when proxy URL includes auth credentials [1.12 backport] #36433

Closed
gopherbot opened this issue Jan 7, 2020 · 2 comments
Closed

net/http: racing write to t.ProxyConnectHeader in dialConn when proxy URL includes auth credentials [1.12 backport] #36433

gopherbot opened this issue Jan 7, 2020 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.15

Comments

@gopherbot
Copy link

@bcmills requested issue #36431 to be considered for backport to the next 1.12 minor release.

@gopherbot, please backport to Go 1.13 and 1.12.

This is a data race in net/http, and the fix is straightforward.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 7, 2020
@gopherbot gopherbot mentioned this issue Jan 7, 2020
Closed
@gopherbot gopherbot added this to the Go1.12.15 milestone Jan 7, 2020
@bradfitz bradfitz added the CherryPickApproved Used during the release process for point releases label Jan 7, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 7, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/213677 mentions this issue: [release-branch.go1.12] net/http: avoid writing to Transport.ProxyConnectHeader

@gopherbot
Copy link
Author

Closed by merging c5af2aa to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Jan 7, 2020
[release-branch.go1.12] net/http: avoid writing to Transport.ProxyCon…
c5af2aa 
…nectHeader

Previously, we accidentally wrote the Proxy-Authorization header for
the initial CONNECT request to the shared ProxyConnectHeader map when
it was non-nil.

Updates #36431
Fixes #36433

Change-Id: I5cb414f391dddf8c23d85427eb6973f14c949025
Reviewed-on: https://go-review.googlesource.com/c/go/+/213638
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 249c85d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/213677
@golang golang locked and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.15
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot