Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: extra autocompletion after complete keyword #36363

Closed
stamblerre opened this issue Jan 2, 2020 · 2 comments
Closed

x/tools/gopls: extra autocompletion after complete keyword #36363

stamblerre opened this issue Jan 2, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@stamblerre
Copy link
Contributor

Screen Shot 2020-01-02 at 1 44 57 PM

In this example, the full keyword true was typed, but it was still the 3rd ranked completion, which results in VS Code auto-inserting it if a user hits enter (intending to go to the next line).

/cc @muirdm

@gopherbot gopherbot added this to the Unreleased milestone Jan 2, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 2, 2020
@muirdm
Copy link

muirdm commented Jan 2, 2020

Yeah I've been meaning to fix this. It is because true is an untyped bool which gets a score penalty. I'll fix it to not penalize builtin constants.

@gopherbot
Copy link

Change https://golang.org/cl/213137 mentions this issue: internal/lsp/source: don't dowrank builtin constant completions

@stamblerre stamblerre modified the milestones: Unreleased, gopls v1.0 Jan 6, 2020
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.4.0 Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants