Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: add -race flag explanation on "go help testflag" #36329

Closed
oomichi opened this issue Dec 31, 2019 · 3 comments
Closed

cmd/go: add -race flag explanation on "go help testflag" #36329

oomichi opened this issue Dec 31, 2019 · 3 comments
Labels
Documentation FrozenDueToAge

Comments

@oomichi
Copy link

oomichi commented Dec 31, 2019

What version of Go are you using (go version)?

$ go version
go version go1.13.5 linux/amd64
$

Does this issue reproduce with the latest release?

Run $ go help testflag and see the lack of explanation for -race flag.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/oomichi/.cache/go-build"
GOENV="/home/oomichi/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/oomichi/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/oomichi/go/src/k8s.io/kubernetes/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build234417289=/tmp/go-build -gno-record-gcc-switches"
$

What did you do?

What did you expect to see?

I'd like to see the explanation of "-race" flag to know the behavior.

What did you see instead?

I cannot see it.
@mvdan
Copy link
Member

mvdan commented Dec 31, 2019

It's in go help build, which you can see mentioned in go help test:

For more about build flags, see 'go help build'.

It's a build flag, not a test flag, so it doesn't belong in testflag.

@cagedmantis cagedmantis changed the title doc: Add -race flag explanation on "go help testflag" cmd/go: add -race flag explanation on "go help testflag" Jan 2, 2020
@cagedmantis
Copy link
Contributor

Thank you for creating an issue @oomichi. I believe @mvdan's response shows that it's working as expected. Please feel free to re-open the issue if you disagree or if I misunderstood.

@oomichi
Copy link
Author

oomichi commented Jan 6, 2020

@mvdan Thanks for your explanation, I got the meaning.
@cagedmantis Yes, @mvdan's response is good for me, it is fine to keep this as closed.

Thanks for your help :-)

@golang golang locked and limited conversation to collaborators Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cagedmantis @oomichi @mvdan @gopherbot