Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/releasebot: Beta release should always run tests #36171

Closed
toothrot opened this issue Dec 16, 2019 · 3 comments
Closed

x/build/cmd/releasebot: Beta release should always run tests #36171

toothrot opened this issue Dec 16, 2019 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

The releasebot skips running tests in mode=release, as we have normally run tests on the commit we're about to release. For beta releases, it's possible that a commit has been merged to master between the time we've run mode=prepare and mode=release.
@gopherbot gopherbot added this to the Unreleased milestone Dec 16, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 16, 2019
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 16, 2019
@toothrot toothrot self-assigned this Dec 16, 2019
@gopherbot
Copy link

Change https://golang.org/cl/211583 mentions this issue: cmd/releasebot: run tests in mode=release for betas

@toothrot
Copy link
Contributor Author

Long-term solution captured in #36182

@gopherbot
Copy link

Change https://golang.org/cl/235777 mentions this issue: cmd/releasebot: use same master commit for beta releases

gopherbot pushed a commit to golang/build that referenced this issue Jun 1, 2020
@dmitshur
cmd/releasebot: use same master commit for beta releases
83d1cf6 
The prepare mode is responsible for doing testing to ensure
all tests are passing. If a problem is found, it can be fixed
and the prepare mode should be re-done.

The release mode is responsible for taking the well-tested
commit from the prepare mode, and using it to build the release.

For beta releases, the master branch is used, and a commit has a
chance of landing between the time the prepare and release modes
are started.

Instead of fetching the latest master commit in release mode,
start reusing the same master commit that was already tested
in prepare mode.

Fixes golang/go#36182.
For golang/go#36171.

Change-Id: Ibf8052ef385cb0a1ffed372ae3e0ed0a9575882f
Reviewed-on: https://go-review.googlesource.com/c/build/+/235777
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@toothrot @gopherbot