Skip to content

x/build/cmd/retrybuilds: support wiping non-"go" repos #36131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradfitz opened this issue Dec 13, 2019 · 3 comments
Closed

x/build/cmd/retrybuilds: support wiping non-"go" repos #36131

bradfitz opened this issue Dec 13, 2019 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

x/build/cmd/retrybuilds has a comment:

// Only the main go repo is currently supported.

Likewise, the dashboard's clear results handler:

// clearResultsHandler purge a single build failure from the dashboard.                                                                                                                             
// It currently only supports the main Go repo.                                                                                                                                                     
func clearResultsHandler(r *http.Request) (interface{}, error) {                                 
...
        _, err := datastoreClient.RunInTransaction(ctx, func(tx *datastore.Transaction) error {
                c := &Commit{
                        PackagePath: "", // TODO(adg): support clearing sub-repos                                                                                                                   
...

Likewise, the dashboard's failures view (as used by retrybuilds) only lists the main repo.

All three would need love.
@bradfitz bradfitz added help wanted FeatureRequest Issues asking for a new feature that does not need a proposal. labels Dec 13, 2019
@gopherbot gopherbot added this to the Unreleased milestone Dec 13, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 13, 2019
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 13, 2019
@darkLord19
Copy link
Contributor

darkLord19 commented Dec 20, 2019 •
edited
Loading

Hey @bradfitz , I'd like to take on this issue but I don't have much idea about x/build so, can you give some pointers on the same. That'd be very helpful.

@bradfitz
Copy link
Contributor Author

bradfitz commented Jan 6, 2020

@darkLord19, sorry, I don't have time to mentor somebody outside the Go team through this codebase. From past experience, ongoing contributors to x/build are extremely few & far between (despite people's ambitions & intentions) and any time invested in teaching people how to hack on this codebase doesn't pay off. (That is, it's much faster to do it myself, and I'm not currently prioritizing it.)

That said, I'm not saying we won't take a change from you for this, but you'll need to put in the effort to learn the codebase yourself first.

@dmitshur dmitshur mentioned this issue Sep 9, 2020
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/600855 mentions this issue: retrybuilds: rewrite tool to support LUCI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @toothrot @gopherbot @darkLord19