Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: "attempt to execute system stack code on user stack" during heap scavenging [1.13 backport] #36127

Closed
gopherbot opened this issue Dec 13, 2019 · 5 comments
Closed

runtime: "attempt to execute system stack code on user stack" during heap scavenging [1.13 backport] #36127

gopherbot opened this issue Dec 13, 2019 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.6

Comments

@gopherbot
Copy link

@aclements requested issue #34773 to be considered for backport to the next 1.13 minor release.

@gopherbot, please open a backport to 1.13.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 13, 2019
@gopherbot gopherbot mentioned this issue Dec 13, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.6 milestone Dec 13, 2019
@aclements
Copy link
Member

@mknyszek, would you mind preparing a quick backport CL for this?

@mknyszek
Copy link
Contributor

Sorry! Slipped under my radar. On it.

@gopherbot
Copy link
Author

Change https://golang.org/cl/212103 mentions this issue: [release-branch.go1.13] runtime: call goready in wakeScavenger instead of ready

@dmitshur
Copy link
Contributor

dmitshur commented Dec 19, 2019 •
edited

Approving this for Go 1.13 because it is a serious problem (programs may crash when certain rare conditions are met) without a workaround. The fix is small.

This does not need to be backported to Go 1.12 as well because it is not an issue on that release branch.

/cc @toothrot @cagedmantis

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Dec 19, 2019
gopherbot pushed a commit that referenced this issue Dec 19, 2019
@mknyszek @dmitshur
[release-branch.go1.13] runtime: call goready in wakeScavenger instea…
b0a2a81 
…d of ready

This changes fixes an oversight in wakeScavenger which would cause ready
to be called off of the system stack. This change makes it so that
wakeScavenger calls goready, which switches to the system stack before
calling ready.

Fixes #36127.

Change-Id: Icb13f180b4d8fdd47c921eac1b896e3dd49e43b3
Reviewed-on: https://go-review.googlesource.com/c/go/+/200999
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 2c87be4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/212103
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
@gopherbot
Copy link
Author

Closed by merging b0a2a81 to release-branch.go1.13.

@golang golang locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.6
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @aclements @gopherbot