Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestPipeEOF failures with "timed out waiting for read" #36107

Closed
bcmills opened this issue Dec 12, 2019 · 7 comments
Closed

os: TestPipeEOF failures with "timed out waiting for read" #36107

bcmills opened this issue Dec 12, 2019 · 7 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 12, 2019 •
edited 

#!watchflakes
post <- pkg == "os" && test == "TestPipeEOF" && `timed out waiting for read`

2019-12-12T13:32:03-c39cd41/darwin-amd64-10_14:

--- FAIL: TestPipeEOF (1.08s)
    pipe_test.go:378: line 0
    pipe_test.go:378: line 1
    pipe_test.go:378: line 2
    pipe_test.go:386: timed out waiting for read
FAIL
FAIL	os	2.452s

See previously #35275, which had a very similar failure mode but with an additional file already closed message at the end.

This is the only failure I could find after CL 204800.

CC @ianlancetaylor
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 12, 2019
@bcmills bcmills added this to the Backlog milestone Dec 12, 2019
@bcmills bcmills mentioned this issue Feb 19, 2021
Closed
@bcmills

This comment has been minimized.

Sign in to view
@bcmills bcmills changed the title os: TestPipeEOF failure on darwin-amd64-10_14 builder os: TestPipeEOF failures with "timed out waiting for read" Feb 19, 2021
@bcmills
Copy link
Contributor Author

bcmills commented Feb 19, 2021

2020-08-17T14:50:17-7ee2622/solaris-amd64-oraclerel
2020-06-18T20:58:26-a07e281/solaris-amd64-oraclerel
2020-02-07T18:06:58-ff091b5/solaris-amd64-oraclerel

@bcmills
Copy link
Contributor Author

bcmills commented Dec 10, 2021

A more thorough history, including a failure in 2021:

greplogs --dashboard -md -l -e 'FAIL: TestPipeEOF .*\n(?: .*\n)* .*: timed out waiting for read'

2021-03-25T19:24:25-569c86d/darwin-amd64-10_14
2020-08-17T14:50:17-7ee2622/solaris-amd64-oraclerel
2020-06-18T20:58:26-a07e281/solaris-amd64-oraclerel
2020-02-07T18:06:58-ff091b5/solaris-amd64-oraclerel
2019-12-12T13:32:03-c39cd41/darwin-amd64-10_14
2019-11-04T10:13:30-1b2ff10/aix-ppc64
2019-11-02T21:51:09-61fa798/aix-ppc64
2019-11-01T00:04:51-4a09a9b/aix-ppc64
2019-10-31T21:47:51-15bff20/windows-amd64-2016
2019-10-31T16:02:25-d5caea7/aix-ppc64

@bcmills
Copy link
Contributor Author

bcmills commented Dec 13, 2022

This test has an arbitrary short timeout:
https://cs.opensource.google/go/go/+/master:src/os/pipe_test.go;l=400;drc=9839668b5619f45e293dd40339bf0ac614ea6bee

It also has several moderately long (10ms) sleeps, whose purpose isn't obvious:
https://cs.opensource.google/go/go/+/master:src/os/pipe_test.go;l=368;drc=9839668b5619f45e293dd40339bf0ac614ea6bee

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Dec 13, 2022
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 13, 2022
@ianlancetaylor
Copy link
Contributor

The sleeps come straight from the test case in #24164. I expect it could be written better.

@gopherbot
Copy link

Change https://go.dev/cl/457336 mentions this issue: os: deflake TestPipeEOF

@bcmills bcmills self-assigned this Dec 13, 2022
@bcmills bcmills modified the milestones: Backlog, Go1.21 Dec 13, 2022
@bcmills bcmills mentioned this issue Dec 15, 2022
Open
@gopherbot
Copy link

Change https://go.dev/cl/458015 mentions this issue: os: clean up tests

gopherbot pushed a commit that referenced this issue Jan 19, 2023
@gopherbot
os: clean up tests
e49cb02 
- Use testenv.Command instead of exec.Command to try to get more
  useful timeout behavior.

- Parallelize tests that appear not to require global state.
  (And add explanatory comments for a few that are not
  parallelizable for subtle reasons.)

- Consolidate some “Helper” tests with their parent tests.

- Use t.TempDir instead of os.MkdirTemp when appropriate.

- Factor out subtests for repeated test helpers.

For #36107.
Updates #22315.

Change-Id: Ic24b6957094dcd40908a59f48e44c8993729222b
Reviewed-on: https://go-review.googlesource.com/c/go/+/458015
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
@bcmills bcmills mentioned this issue Sep 19, 2023
Open
@golang golang locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@ianlancetaylor @bcmills @gopherbot