Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: proxied connection can be spuriously closed after dialConn as of CL 210286 #36070

Closed
bcmills opened this issue Dec 10, 2019 · 9 comments
Closed

net/http: proxied connection can be spuriously closed after dialConn as of CL 210286 #36070

bcmills opened this issue Dec 10, 2019 · 9 comments
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 10, 2019

A timeout in net/http.TestTransportProxy seems to have started around CL 210286:

panic: test timed out after 3m0s

goroutine 2138 [running]:
testing.(*M).startAlarm.func1()
	/workdir/go/src/testing/testing.go:1422 +0x9
created by time.goFunc
	/workdir/go/src/time/sleep.go:168 +0x5

[…]

goroutine 2125 [chan receive]:
net/http_test.TestTransportProxy.func1(0xb08360)
	/workdir/go/src/net/http/transport_test.go:1424 +0x5a
testing.tRunner(0xb08360, 0xa3af60)
	/workdir/go/src/testing/testing.go:954 +0xc
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1005 +0x30

[…]

goroutine 2107 [chan receive, 2 minutes]:
testing.(*T).Run(0xb08360, 0xa62860, 0x20, 0xa3af60, 0x2)
	/workdir/go/src/testing/testing.go:1006 +0x31
net/http_test.TestTransportProxy(0x875d40)
	/workdir/go/src/net/http/transport_test.go:1324 +0x6
testing.tRunner(0x875d40, 0x13aca0)
	/workdir/go/src/testing/testing.go:954 +0xc
created by testing.(*T).Run
	/workdir/go/src/testing/testing.go:1005 +0x30
FAIL	net/http	184.130s

2019-12-09T21:50:59-3a3093d/js-wasm
2019-12-09T20:19:32-7d24e95/js-wasm
2019-12-09T16:41:15-a3a630b/js-wasm

CC @bradfitz @ianlancetaylor
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) arch-wasm WebAssembly issues labels Dec 10, 2019
@bcmills bcmills added this to the Go1.14 milestone Dec 10, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Dec 10, 2019

That CL was the fix for #28012.

@bradfitz
Copy link
Contributor

It passed the trybots at the time.

Does a js-wasm net.Conn not reliably interrupt a blocked Read on Close or something?

I'm fine just skipping that test on js-wasm for now.

@bcmills
Copy link
Contributor Author

bcmills commented Dec 10, 2019

I don't know the underlying cause of the failure. The failure rate seems to be around 50%, which would explain the passing TryBot.

@bcmills
Copy link
Contributor Author

bcmills commented Dec 10, 2019

(CC @neelance @cherrymui for the question about the js-wasm net implementation.)

@bradfitz
Copy link
Contributor

The new code in CL 210286 adds a 1 minute timeout reading the CONNECT response if no context deadline was otherwise present.

It's possible the net/http tests are just so slow on wasm that it's straddling that 1 minute timeout already (~50% of the time?) with all the parallel tests. But, uh, TestTransportProxy isn't t.Parallel.

@gopherbot
Copy link

Change https://golang.org/cl/210737 mentions this issue: net/http: set a context deadline in HEAD request in test

@bcmills
Copy link
Contributor Author

bcmills commented Dec 10, 2019

Found the bug, I think:
https://go-review.googlesource.com/c/go/+/210286/2/src/net/http/transport.go#1588

@bcmills bcmills changed the title net/http: TestTransportProxy timing out on js-wasm builder after CL 210286 net/http: proxied connection can be spuriously closed after DialConn as of CL 210286 Dec 10, 2019
@bcmills bcmills changed the title net/http: proxied connection can be spuriously closed after DialConn as of CL 210286 net/http: proxied connection can be spuriously closed after dialConn as of CL 210286 Dec 10, 2019
@bradfitz
Copy link
Contributor

Whoops, thanks!

@gopherbot
Copy link

Change https://golang.org/cl/210738 mentions this issue: net/http: fix timeout race in Transport proxy CONNECT

@bcmills bcmills mentioned this issue Dec 11, 2019
Closed
@golang golang locked and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
3 participants
@bradfitz @bcmills @gopherbot