Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

Change https://golang.org/cl/210558 mentions this issue: internal/lsp: fix control flow taking precedence

Thanks for looking at this. Out of curiosity why do we highlight the entire return statement instead of just the "return" keyword? If the return statement is long (esp if multiline), it's really a lot of highlighting. Similarly we highlight the entire composite literal (body) instead of just the composite literal's type name when highlighting on the type name (e.g. foo{ in the example above).

We looked at what Goland does when it comes to highlighting inside of a return statement and if you highlight any field in the return list, then it will highlight the entire field and the corresponding param in the return list within the function declaration. For instance,

func test() (bool, int) {
    return false, 1;
}

When you highlight false, it will also highlight bool and if you highlight bool it will highlight all the first fields for each return statement.

In the case that you used as an example, if you just highlight the foo in the type declaration, it will only highlight the composite literal's type name, not the whole body. Highlighting inside the return statement is the only case where the whole body would get highlighted.

Thanks for the explanation. I didn't realize it was connected to the function results like that.