Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mod/zip: symlink test failing on Plan 9 #36041

Closed
fhs opened this issue Dec 7, 2019 · 1 comment
Closed

x/mod/zip: symlink test failing on Plan 9 #36041

fhs opened this issue Dec 7, 2019 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@fhs
Copy link
Contributor

fhs commented Dec 7, 2019 •
edited
Loading

From the plan9-386 builder (see https://build.golang.org/log/f5677df57ee06b21a6036f7c6eaddc58dd2df91d):

--- FAIL: TestCreateFromDirSpecial (0.01s)
    --- FAIL: TestCreateFromDirSpecial/ignore_symlink (0.00s)
        zip_test.go:277: symlink /tmp/TestCreateFromDirSpecial-ignore_symlink967578448 /tmp/TestCreateFromDirSpecial-ignore_symlink967578448/link: not supported by plan 9
FAIL
FAIL	golang.org/x/mod/zip	0.149s

The test is currently being skipped on Windows if symlink creation fails. It should be skipped on Plan 9 also.

@gopherbot Please add labels OS-Plan9, NeedsFix, Testing
@gopherbot gopherbot added this to the Unreleased milestone Dec 7, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/210397 mentions this issue: zip: skip symlink test on Plan 9

@golang golang locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@fhs @gopherbot