Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/memoize: return error from Get #36004

Closed
stamblerre opened this issue Dec 5, 2019 · 2 comments
Closed

x/tools/internal/memoize: return error from Get #36004

stamblerre opened this issue Dec 5, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@stamblerre
Copy link
Contributor

Calling Get on a handle does not propagate an error if the handle is nil, which forces extra logic into clients of this package.

/cc @heschik

@gopherbot gopherbot added this to the Unreleased milestone Dec 5, 2019
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 5, 2019
@heschi
Copy link
Contributor

heschi commented Dec 5, 2019

*if the context is cancelled

@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 6, 2019
@stamblerre stamblerre added the gopls Issues related to the Go language server, gopls. label May 22, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 May 26, 2020
@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Jun 24, 2020
@gopherbot
Copy link

Change https://golang.org/cl/239564 mentions this issue: internal/memoize: add an error return to (*handle).Get

@golang golang locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants