Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: flaky implementations results for embedded types #35972

Closed
muirdm opened this issue Dec 4, 2019 · 2 comments
Closed

x/tools/gopls: flaky implementations results for embedded types #35972

muirdm opened this issue Dec 4, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@muirdm
Copy link

muirdm commented Dec 4, 2019

In an unrelated change I fixed the import line in "internal/lsp/testdata/implementation/implementation.go" and that made the below test start flaking:

type U interface {
	U() //@mark(IntU, "U"),implementations("U", ImpU),
}

It fails when "implementation" package's "Foo" type wins the dedupe check. implementation.Foo's "U" method lies in another package, which breaks the code that tries to look up the methods file/position. It works if "other.Foo" wins since "U" is implemented in the "other" package.

We need to fix the bug and then re-enable the test.

@gopherbot gopherbot added this to the Unreleased milestone Dec 4, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 4, 2019
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@stamblerre stamblerre modified the milestones: Unreleased, gopls v1.0 Dec 4, 2019
@gopherbot
Copy link

Change https://golang.org/cl/210280 mentions this issue: internal/lsp: fix find-implementation for promoted methods

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.4.0 Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants