net/http/httputil: add sort by quality #3594
Labels
Milestone
Comments
|
Comment 1 by raul.san@sent.com: Note: substitute variable "lang" by another name like "key". |
Agreed. There was a CL containing this awhile back that didn't make Go 1. We should probably add this at some point, either in http or httputil. Owner changed to @bradfitz. Status changed to Accepted. |
|
Comment 3 by raul.san@sent.com: I've added a file with a bug fixed, and returning the parameters with zero value too since the server could use it for statistic (which arguments want not the clients). Attachments:
|
|
Comment 4 by raul.san@sent.com: I've added a file with a bug fixed, and returning the parameters with zero value too since the server could use it for statistic (which arguments want not the clients). Attachments:
|
|
Comment 5 by raul.san@sent.com: I've added a file with a bug fixed, and returning the parameters with zero value too since the server could use it for statistic (which arguments want not the clients). Attachments:
|
I'm interested in working on this since I have some code that implements some of this already. The code I have currently returns not only the value but also its quality as a float. Do we want this? or just a sorted list of the values? It would mean you'd need a type instead of getting a []string, but on the other hand you don't need two return values because you could put the values with a 0 q in the same slice. |
gopherbot
added
accepted
Suggested
|
There seems to be lack of interest to add this, and/or lack of need, so I'm going to close this for now. I'm happy to entertain a patch if anybody cares enough later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by raul.san@sent.com:
There is an usefull method which could be added to the type Request in package "net/http" type Reverse struct { // This embedded Interface permits Reverse to use the methods of // another Interface implementation. sort.Interface } // Less returns the opposite of the embedded implementation's Less method. func (r Reverse) Less(i, j int) bool { return r.Interface.Less(j, i) } // parseQualityValues returns the fields sorted by its greater quality level. // Returns nil if there are no values associated with the header. // // [HTTP spec](http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html) // [Quality Values](http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.9) func parseQualityValues(r *http.Request, header string) []string { valHeader := r.Header.Get(header) if len(valHeader) == 0 { return nil } qValues := make(map[float64][]string) qSorted := make([]float64, 0) result := make([]string, 0) // Example of string to parse for the header Accept-Language: // da, en-gb;q=0.8, en;q=0.7 for _, f := range strings.Split(valHeader, ",") { lang := "" q := 1.0 // default if strings.ContainsRune(f, ';') { q_ := strings.Split(f, "=")[1] q_ = strings.Trim(q_, " ") q, _ = strconv.ParseFloat(q_, 64) if q == 0 { // content not acceptable for the client continue } lang = strings.Split(f, ";")[0] lang = strings.Trim(lang, " ") } else { lang = strings.Trim(f, " ") } if _, ok := qValues[q]; !ok { qValues[q] = make([]string, 0) } qValues[q] = append(qValues[q], lang) qSorted = append(qSorted, q) } sort.Sort(Reverse{sort.Float64Slice(qSorted)}) for _, v := range qSorted { result = append(result, qValues[v]...) } return result }The text was updated successfully, but these errors were encountered: