Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add extra testdata in gopls module #35880

Closed
stamblerre opened this issue Nov 27, 2019 · 3 comments
Closed

x/tools/gopls: add extra testdata in gopls module #35880

stamblerre opened this issue Nov 27, 2019 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@stamblerre
Copy link
Contributor

CL 209220 doesn't work because the diff algorithm in golang.org/x/tools/internal/lsp doesn't support sub-line diffs. We should probably have a way to add extra testdata in the golang.org/x/tools/gopls so that we can add extra tests that only work inside of that module.

/cc @ianthehat @heschik
@gopherbot gopherbot added this to the Unreleased milestone Nov 27, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 27, 2019
@stamblerre stamblerre added NeedsFix The path to resolution is known, but the work has not been done. help wanted labels Nov 27, 2019
@stamblerre stamblerre modified the milestones: Unreleased, gopls unplanned Dec 4, 2019
@gopherbot
Copy link

Change https://golang.org/cl/214280 mentions this issue: internal/lsp: fix link handling for links without schemes

gopherbot pushed a commit to golang/tools that referenced this issue Jan 10, 2020
@stamblerre
internal/lsp: fix link handling for links without schemes
945ed6e 
Unfortunately, this can't be tested until golang/go#35880 is resolved,
because only the third-party xurls library detects links without
schemes.

Change-Id: I620581d6ce99c79ae89f3f22ea8ee634c3850a8e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/214280
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@stamblerre stamblerre added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jan 13, 2020
@stamblerre stamblerre modified the milestones: gopls unplanned, gopls testing, Unreleased Jan 29, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Apr 8, 2020
@gopherbot
Copy link

Change https://golang.org/cl/227559 mentions this issue: internal/lsp: linkify IP addresses in textDocument/documentLink

gopherbot pushed a commit to golang/tools that referenced this issue Apr 10, 2020
@stamblerre
internal/lsp: linkify IP addresses in textDocument/documentLink
c08edad 
Found golang/go#18824, which helped me understand what to do to fix this
issue. Also, changed some of the structure of the code to propagate
errors up to the top-level functions. I think this will help us deal
with actual errors vs. ignorable errors.

Didn't add tests because of golang/go#35880. Just prioritized that issue
for gopls/v0.5.0 - it's been biting us a lot lately.

Fixes golang/go#38285

Change-Id: I6962462818becb1bcedde4a5be3a2060e71c9389
Reviewed-on: https://go-review.googlesource.com/c/tools/+/227559
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Jun 24, 2020
@stamblerre stamblerre mentioned this issue Jun 24, 2020
Open
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
@findleyr
Copy link
Contributor

findleyr commented Sep 7, 2023

This is obsolete as all the code is now in the gopls module.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. help wanted NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr