Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: errors when navigating through git ir gitlens URIs do not disappear anymore #35846

Closed
inliquid opened this issue Nov 26, 2019 · 2 comments
Closed

x/tools/gopls: errors when navigating through git ir gitlens URIs do not disappear anymore #35846

inliquid opened this issue Nov 26, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@inliquid
Copy link

  1. VS Code
  2. gopls@master

Previously these errors would disappear after git or gitlens tab was closed. Now they stay until language server restart.

изображение
@gopherbot gopherbot added this to the Unreleased milestone Nov 26, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 26, 2019
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@stamblerre
Copy link
Contributor

This is a result of CL 208237, which removed the previous behavior of clearing diagnostics when a file was closed. This change was made because gopls now shows diagnostics for an entire workspace. I think the right approach here will be for us to handle these files correctly (without showing errors). As a result, I will close this issue in favor of #33699.

@golang golang locked and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@stamblerre @inliquid @gopherbot